feat: Propagate traceId to the Cocoa SDK#2106
Merged
bitsandfoxes merged 50 commits intomainfrom Apr 22, 2025
Merged
Conversation
Contributor
|
16 tasks
bruno-garcia
approved these changes
Apr 10, 2025
| return cString; | ||
| } | ||
|
|
||
| void SentryNativeBridgeSetTrace(const char *traceId, const char *spanId) |
Member
There was a problem hiding this comment.
is the iOS and Mac bridges the same? I wonder if we could use symlinks
Contributor
Author
There was a problem hiding this comment.
Unfortunately, they are not. Functionally, yes, but we load the lib dynamically on macOS:
sentry-unity/package-dev/Plugins/macOS/SentryNativeBridge.m
Lines 97 to 105 in 16e21d8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change the Unity SDK is propagating the trace down to the Cocoa SDK. This allows connecting native errors and crashes with the ones from within the game.
Relies on getsentry/sentry-cocoa#5081